Exclude built code folders from stylistic PHPCS rules#342
Merged
Conversation
By rights these paths should already be phpcs-ignored per project, this makes that behavior more default
rmccue
approved these changes
Jun 26, 2026
rmccue
left a comment
rmccue
left a comment
Member
There was a problem hiding this comment.
I think this makes sense; I assume because this isn't prefixed with * that eg inc/tools/build/foo.php would still be included?
Collaborator
Author
Correct! |
kadamwhite
changed the title
kadamwhite
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built asset files are standard under current wp-scripts best practices, so our ruleset should not enforce human-authorship-oriented sniffs on these autogenerated files.
I've limited our exclusions to the default
build/and oft-useddist/folder prefixes.